Messages in this thread | | | Date | Fri, 21 Oct 2022 15:47:21 +0300 | Subject | Re: [PATCH v4 2/3] iio: accel: Support Kionix/ROHM KX022A accelerometer | From | Matti Vaittinen <> |
| |
On 10/21/22 15:41, Andy Shevchenko wrote: > On Fri, Oct 21, 2022 at 02:22:49PM +0300, Matti Vaittinen wrote: >> KX022A is a 3-axis accelerometer from ROHM/Kionix. The sensor features >> include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ, >> tap/motion detection, wake-up & back-to-sleep events, four acceleration >> ranges (2, 4, 8 and 16g), and probably some other cool features. >> >> Add support for the basic accelerometer features such as getting the >> acceleration data via IIO. (raw reads, triggered buffer [data-ready] or >> using the WMI IRQ). >> >> Important things to be added include the double-tap, motion >> detection and wake-up as well as the runtime power management. > > While I have some disagreements on some code > pieces, this version is okay to go I think. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks for the thorough review Andy.
> Below a few nit-picks in case it needs to be a v5.
Just a note that I do agree with these 'nits'. I'll fix them if I need to respin the series.
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |