lkml.org 
[lkml]   [2022]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dt-bindings: rtc: add bindings for max313xx RTCs
On 21/10/2022 11:44:12+0000, Tilki, Ibrahim wrote:
> > > + interrupt-names:
> > > + description: |
> > > + Name of the interrupt pin of the RTC used for IRQ. Not required for
> > > + RTCs that only have single interrupt pin available. Some of the RTCs
> > > + share interrupt pins with clock input/output pins.
> > > + minItems: 1
> > > + items:
> > > + - enum: [INTA, INTB]
> > > + - enum: [INTA, INTB]
> > > +
> >
> > I don't think this is right, what this is doing is essentially pinmuxing
> > interrupts versus clocks. What happens if you want INTB but this goes
> > directly to a PMIC instead of the SoC?
> > It is not something you can express with your current bindings.
> >
>
> Why would a user want INTB when it is not connected to SoC?
> User can specify none, either one or both of the interrupt pins.
> I don't see what the problem here is.
>

the interrupt pin may be connected to a PMIC that is able to start or
wake up the platform. In that case, the user would not have any
interrupt-names and your driver will fail to mux the interrupt on INTB.
Please fix.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2022-10-21 14:30    [W:0.478 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site