Messages in this thread | | | Date | Fri, 21 Oct 2022 11:44:54 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 3/7] arm64/sysreg: Convert SPE registers to automatic generation |
| |
On Thu, Oct 20, 2022 at 02:51:02PM -0500, Rob Herring wrote: > On Thu, Oct 20, 2022 at 9:33 AM Mark Brown <broonie@kernel.org> wrote:
> > > +Field 11:8 EA
> > This looks like it should be described as an enum.
> 0b0000 Not_Described > 0b0001 Ignored > 0b0010 SError
> What's the preferred case here?
Either option is good for case I think, it's a taste question - going with upper case is more the kernel coding style so fine there, though sometimes it makes things hard to read. [unhandled content-type:application/pgp-signature] | |