Messages in this thread | | | Date | Fri, 21 Oct 2022 11:37:54 +0200 | From | Borislav Petkov <> | Subject | Re: [RESEND PATCH V2 4/9] x86/msr: Add the MSR definition for AMD CPPC boost state |
| |
On Fri, Oct 21, 2022 at 01:22:11PM +0800, Huang Rui wrote: > > > If I rename that the MSR definition string, that will cause lots of driver file > > > change. > > > So I suggest to add one new MSR macro for the CPPC, the MSR_K7_HWCR is > > > mismatching in the CPPC Pstate driver. > > > If you refuse to use this new one, I will reuse that old one. > > > > To avoid changing too much stuff at once how about if you give an alias? > > IE something like: > > > > #define MSR_AMD_CPPC_HW_CTL MSR_K7_HWCR
Why would you all even think about adding a new name and not use MSR_K7_HWCR?
The other code uses it just fine, do git grep MSR_K7_HWCR.
We have waaay too many MSRs, no need to unnecessarily confuse people with an alias or rename stuff. Just use MSR_K7_HWCR like everything else does.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |