Messages in this thread | | | Date | Fri, 21 Oct 2022 10:00:16 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops |
| |
On Fri, Oct 21, 2022 at 10:41:22AM +0200, Frank Wunderlich wrote: > Am 21. Oktober 2022 09:24:02 MESZ schrieb "Russell King (Oracle)" <linux@armlinux.org.uk>: > >On Fri, Oct 21, 2022 at 08:04:51AM +0200, Frank Wunderlich wrote: > >> On my board (bpi-r3) we have no autoneg on the gmacs. We have a switch (mt7531) with fixed-link on the first and a sfp-cage on the other. Second mac gets speed-setting (1000base-X or 2500base-X) from sfp eeprom, but no advertisement from the "other end". Imho it is always full duplex. > > > >If it's a fixed link, then this function you're adding won't be called. > >It's only called for in-band mode which is exclusive with fixed-link > >mode. > > > >-- > >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > >FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > Right, i get this trace for the second mac which is without fixed-link because of in-band-managed for sfp (read speed settings from sfp eeprom).
So, you need to set state->duplex to DUPLEX_FULL if this is what the hardware is actually doing.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |