Messages in this thread | | | Date | Fri, 21 Oct 2022 10:57:08 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v2 03/12] cxl: Unify debug messages when calling devm_cxl_add_port() |
| |
On 20.10.22 17:20:10, Dan Williams wrote: > Robert Richter wrote: > > CXL ports are added in a couple of code paths using devm_cxl_add_ > > port(). Debug messages are individually generated, but are incomplete > > Hmm, devm_cxl_add_port() got wrapped in a few places here. I fixed it up > locally, but maybe take a look at your word wrap to keep function > symbols unbroken in future changelogs.
Ok, will do. Thanks for the note.
> > > and inconsistent. Change this by moving its generation to devm_cxl_ > > add_port(). This unifies the messages and reduces code duplication. > > Also, generate messages on failure. Use a __devm_cxl_add_port() > > wrapper to keep the readability of the error exits. > > Otherwise looks good, applied for v6.2.
Thanks,
-Robert
| |