lkml.org 
[lkml]   [2022]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/8] perf test: Wait for a new thread when testing --per-thread record
From
On 20/10/22 20:26, Namhyung Kim wrote:
> Just running the target program is not enough to test multi-thread
> target because it'd be racy perf vs target startup. I used the
> initial delay but it cannot guarantee for perf to see the thread.
>
> Instead, use wait_for_threads helper from shell/lib/waiting.sh to make
> sure it starts the sibling thread first. Then perf record can use -p
> option to profile the target process.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> tools/perf/tests/shell/record.sh | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 952981481239..d1640d1daf2e 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -4,6 +4,9 @@
>
> set -e
>
> +shelldir=$(dirname "$0")
> +. "${shelldir}"/lib/waiting.sh
> +
> err=0
> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> testprog=$(mktemp /tmp/__perf_test.prog.XXXXXX)
> @@ -96,6 +99,30 @@ test_per_thread() {
> err=1
> return
> fi
> +
> + # run the test program in background (forever)
> + ${testprog} 1 &
> + TESTPID=$!
> +
> + rm -f "${perfdata}"
> +
> + wait_for_threads ${TESTPID} 2
> + perf record -p "${TESTPID}" --per-thread -o "${perfdata}" sleep 1 2> /dev/null
> + kill ${TESTPID}
> +
> + if [ ! -e "${perfdata}" ]
> + then
> + echo "Per-thread record [Failed record -p]"
> + err=1
> + return
> + fi
> + if ! perf report -i "${perfdata}" -q | grep -q "${testsym}"
> + then
> + echo "Per-thread record [Failed -p missing output]"
> + err=1
> + return
> + fi
> +
> echo "Basic --per-thread mode test [Success]"
> }
>

\
 
 \ /
  Last update: 2022-10-21 10:47    [W:0.161 / U:24.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site