Messages in this thread | | | Date | Fri, 21 Oct 2022 10:19:07 +0200 | Subject | Re: [PATCH v3 06/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 | From | AngeloGioacchino Del Regno <> |
| |
Il 20/10/22 14:21, Krzysztof Kozlowski ha scritto: > On 20/10/2022 07:36, Yassine Oudjana wrote: >> >> On Mon, Oct 10 2022 at 07:24:59 -04:00:00, Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> On 07/10/2022 08:59, Yassine Oudjana wrote: >>>> From: Yassine Oudjana <y.oudjana@protonmail.com> >>>> >>>> Combine MT6795 pin controller document into MT6779 one. In the >>>> process, replace the current interrupts property description with >>>> the one from the MT6795 document since it makes more sense. Also >>>> amend property descriptions and examples with more detailed >>>> information that was available in the MT6795 document, and replace >>>> the current pinmux node name patterns with ones from it since they >>>> are more common across mediatek pin controller bindings. >>>> >>>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >>>> --- >>>> .../pinctrl/mediatek,mt6779-pinctrl.yaml | 94 ++++++-- >>>> .../pinctrl/mediatek,pinctrl-mt6795.yaml | 227 >>>> ------------------ >>>> 2 files changed, 77 insertions(+), 244 deletions(-) >>>> delete mode 100644 >>>> Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml >>>> b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml >>>> index a2141eb0854e..cada3530dd0a 100644 >>>> --- >>>> a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml >>>> +++ >>>> b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml >>>> @@ -8,6 +8,7 @@ title: Mediatek MT6779 Pin Controller >>>> >>>> maintainers: >>>> - Andy Teng <andy.teng@mediatek.com> >>>> + - AngeloGioacchino Del Regno >>>> <angelogioacchino.delregno@collabora.com> >>>> - Sean Wang <sean.wang@kernel.org> >>>> >>>> description: >>>> @@ -18,6 +19,7 @@ properties: >>>> compatible: >>>> enum: >>>> - mediatek,mt6779-pinctrl >>>> + - mediatek,mt6795-pinctrl >>>> - mediatek,mt6797-pinctrl >>>> >>>> reg: >>>> @@ -43,9 +45,10 @@ properties: >>>> interrupt-controller: true >>>> >>>> interrupts: >>>> - maxItems: 1 >>>> + minItems: 1 >>>> + maxItems: 2 >>>> description: | >>>> - Specifies the summary IRQ. >>>> + The interrupt outputs to sysirq. >>> >>> I am not sure if description is relevant now for all variants... what >>> is >>> the sysirq? You have two interrupts so both go to one sysirq? >> >> It's the system interrupt controller and it has several inputs. Both >> interrupts go to it. > > Then the naming is confusing because "sysirq" sounds like "system > interrupt". >
Yassine: "Interrupt outputs to the system interrupt controller (sysirq)"
That will surely clear up the confusion... :-)
Cheers, Angelo
| |