lkml.org 
[lkml]   [2022]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning
From
On 21.10.22 07:19, Maria Yu wrote:
> When !CONFIG_VM_BUG_ON, there is warning of
> clang-analyzer-deadcode.DeadStores:
> Value stored to 'mt' during its initialization
> is never read.
>
> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
> ---
> mm/page_isolation.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 04141a9bea70..a7a478a22123 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,
> zone->zone_start_pfn);
>
> if (skip_isolation) {
> - int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));

__maybe_unused should work as well. Was that considered?

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2022-10-21 08:56    [W:0.361 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site