lkml.org 
[lkml]   [2022]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] virtio_pci: use helper function is_power_of_2()
    Date
    From: Shaoqin Huang <shaoqin.huang@intel.com>

    Use helper function is_power_of_2() to check if num is power of two.
    Minor readability improvement.

    Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
    ---
    drivers/virtio/virtio_pci_modern.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
    index c3b9f2761849..207294bd7b9d 100644
    --- a/drivers/virtio/virtio_pci_modern.c
    +++ b/drivers/virtio/virtio_pci_modern.c
    @@ -310,7 +310,7 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
    if (!num || vp_modern_get_queue_enable(mdev, index))
    return ERR_PTR(-ENOENT);

    - if (num & (num - 1)) {
    + if (!is_power_of_2(num)) {
    dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", num);
    return ERR_PTR(-EINVAL);
    }
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-10-21 08:28    [W:3.566 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site