lkml.org 
[lkml]   [2022]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] of: fix repeated words in comments
On Wed, Oct 19, 2022 at 8:39 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> >
> > On 10/19/22 06:02, Jilin Yuan wrote:
> > > Delete the redundant word 'of'.
> > >
> > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > > ---
> > > drivers/of/device.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > index 8cefe5a7d04e..16c7e5a2a868 100644
> > > --- a/drivers/of/device.c
> > > +++ b/drivers/of/device.c
> > > @@ -19,7 +19,7 @@
> > >
> > > /**
> > > * of_match_device - Tell if a struct device matches an of_device_id list
> > > - * @matches: array of of device match structures to search in
> > > + * @matches: array of device match structures to search in
> >
> > Hi,
> > Rob has already explained this at least 2 times.
> >
> > The second "of" is "open firmware".
> > I would write it
> > array of OF device match structures to search in
> > :)
>
> Actually, I'd probably do something like
>
> array of Open Firmware (OF) device match structures...

Or just put the struct name in there: of_device_id

But at this point I prefer to just leave it alone for the
entertainment factor of how many times can I get this patch from
send-only email accts.

Rob

\
 
 \ /
  Last update: 2022-10-20 15:24    [W:0.549 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site