lkml.org 
[lkml]   [2022]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging: rts5208: Replace instances of udelay by usleep_range
On Thu, Oct 20, 2022 at 5:40 AM Joe Perches <joe@perches.com> wrote:
>
> On Tue, 2022-10-18 at 14:04 +0000, Tanjuate Brunostar wrote:
> > Replace the use of udelay by usleep_range as suggested by checkpatch:
> >
> > CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
> > + udelay(30);
> []
> > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> []
> > @@ -3235,7 +3235,7 @@ static int ms_write_multiple_pages(struct rtsx_chip *chip, u16 old_blk,
> > return STATUS_FAIL;
> > }
> >
> > - udelay(30);
> > + usleep_range(30, 30);
>
> >This isn't useful. Please read the Documentation/timers.

Yes I read the documentation and realized the changes were not necessary

\
 
 \ /
  Last update: 2022-10-20 08:09    [W:0.073 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site