lkml.org 
[lkml]   [2022]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC for-next v2 3/4] block/bio: add pcpu caching for non-polling bio_put
> +	unsigned long flags;
>
> cache = per_cpu_ptr(bio->bi_pool->cache, get_cpu());
> bio_uninit(bio);
> @@ -737,12 +776,15 @@ static inline void bio_put_percpu_cache(struct bio *bio)
> cache->free_list = bio;
> cache->nr++;
> } else {
> - put_cpu();
> - bio_free(bio);
> - return;
> + local_irq_save(flags);
> + bio->bi_next = cache->free_list_irq;
> + cache->free_list_irq = bio;
> + cache->nr_irq++;
> + local_irq_restore(flags);
> }

Ok, I guess with that my previous comments don't make quite
as much sense any more. I think youcan keep flags local in
the branch here, though.

\
 
 \ /
  Last update: 2022-10-20 10:32    [W:0.073 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site