Messages in this thread | | | Date | Thu, 20 Oct 2022 09:10:35 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage |
| |
On Tue, Oct 18, 2022 at 06:09:31PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration > ordering issue") overlooked the fact that cmos_do_probe() depended > on the preparations carried out by cmos_wake_setup() and the wake > alarm stopped working after the ordering of them had been changed. > > Address this by partially reverting commit 4919d3eb2ec0 so that > cmos_wake_setup() is called before cmos_do_probe() again and moving > the rtc_wake_setup() invocation from cmos_wake_setup() directly to the > callers of cmos_do_probe() where it will happen after a successful > completion of the latter. > > Fixes: 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration ordering issue") > Reported-by: Zhang Rui <rui.zhang@intel.com> > Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Boot test that previously hit NULL pointer exceptions also completed successfully.
-- Mel Gorman SUSE Labs
| |