Messages in this thread | | | Date | Thu, 20 Oct 2022 17:53:47 -0700 | From | Andrei Vagin <> | Subject | Re: [PATCH 5/5] selftest/seccomp: add a new test for the sync mode of seccomp_user_notify |
| |
On Wed, Oct 19, 2022 at 10:04:44PM -0700, Kees Cook wrote: > On October 19, 2022 6:10:48 PM PDT, Andrei Vagin <avagin@gmail.com> wrote: > >Test output: > >RUN global.user_notification_sync ... > >seccomp_bpf.c:4279:user_notification_sync:basic: 8655 nsec/syscall > >seccomp_bpf.c:4279:user_notification_sync:sync: 2919 nsec/syscall > >OK global.user_notification_sync > > This looks like a benchmark, not a functionality test. But maybe the test is "is sync faster than async?" >
Yes, it is. I found it quite useful for debugging and understanding that everything works as expected. I like the idea to check that sync is faster than async. I will add it and address all your other comments in the next version. Thanks.
| |