Messages in this thread | | | Date | Fri, 21 Oct 2022 06:23:19 +0700 | Subject | Re: BISECT result: 6.0.0-RC kernels trigger Firefox snap bug with 6.0.0-rc3 through 6.0.0-rc7 | From | Bagas Sanjaya <> |
| |
On 10/20/22 22:45, Phillip Lougher wrote: > On 20/10/2022 14:55, Jintao Yin wrote: >> Hi all, >> >> After review the details of page actor, the tail bytes may be written to >> a temp buffer instead the last used page. So before diff would wrongly >> memzero a page which is not the tail bytes in. >> >> In this diff fixes it by caculation of the real index the trailing bytes >> in and check if the last used page matches this index. If the page is >> the real tail bytes in, then memzero the trailing bypte of the page. >> >> Please help test and any feedbacks are welcome. >> >> Thanks, > > This is a rediculously complex patch. Sorry, but, absolute NACK. > > Additionally, it is poor etiquette and pointless to fix an > already fixed issue with a _more_ complex patch. >
Ah! I was about to test his third fixup patch. I prefer to go with your fix instead (as the formal patch).
-- An old man doll... just what I always wanted! - Clara
| |