lkml.org 
[lkml]   [2022]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement
    Hi,

    some comments from me. Thanks for the patch and review!

    > > This version of the patch has been tested on an M1 Ultra Mac Studio,
    > > as well as an M1 MacBook Pro, and userspace launches successfully
    > > while using the IRQ path for I2C transactions.
    > >
    > > Tested-by: Arminder Singh <arminders208@outlook.com>
    >
    > I think it's usually implied that you tested your own patches ;)

    Yes, the tag is superfluous. The paragraph before is nice, though, to
    learn which testing has been applied.

    > > make sure to be more responsive this time around! Also wasn't sure whether
    > > the v1 changelog belonged before or after the '---' so I put it after
    > > to keep the commit changelog short and concise.
    > > (This is just one patch, didn't think it needed a cover letter)

    Both assumptions are correct.

    Happy hacking,

    Wolfram

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-10-02 13:30    [W:4.960 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site