lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 719/862] hwmon: (sht4x) do not overflow clamping operation on 32-bit platforms
    Date
    From: Jason A. Donenfeld <Jason@zx2c4.com>

    [ Upstream commit f9c0cf8f26de367c58e48b02b1cdb9c377626e6f ]

    On 32-bit platforms, long is 32 bits, so (long)UINT_MAX is less than
    (long)SHT4X_MIN_POLL_INTERVAL, which means the clamping operation is
    bogus. Fix this by clamping at INT_MAX, so that the upperbound is the
    same on all platforms.

    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Link: https://lore.kernel.org/r/20220924101151.4168414-1-Jason@zx2c4.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/sht4x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwmon/sht4x.c b/drivers/hwmon/sht4x.c
    index c19df3ade48e..13ac2d8f22c7 100644
    --- a/drivers/hwmon/sht4x.c
    +++ b/drivers/hwmon/sht4x.c
    @@ -129,7 +129,7 @@ static int sht4x_read_values(struct sht4x_data *data)

    static ssize_t sht4x_interval_write(struct sht4x_data *data, long val)
    {
    - data->update_interval = clamp_val(val, SHT4X_MIN_POLL_INTERVAL, UINT_MAX);
    + data->update_interval = clamp_val(val, SHT4X_MIN_POLL_INTERVAL, INT_MAX);

    return 0;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:59    [W:4.033 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site