lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 740/862] drm/amd/display: Fix variable dereferenced before check
    Date
    From: sunliming <sunliming@kylinos.cn>

    [ Upstream commit 45a92f45f4578ff89da7dc5ef50bab4ef870f3b7 ]

    Fixes the following smatch warning:

    drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:311 dc_dmub_srv_p_state_delegate()
    warn: variable dereferenced before check 'dc' (see line 309)

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: sunliming <sunliming@kylinos.cn>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
    index 76c05ff12e95..755c4f9de6da 100644
    --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
    +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
    @@ -323,11 +323,13 @@ bool dc_dmub_srv_p_state_delegate(struct dc *dc, bool should_manage_pstate, stru
    struct dmub_cmd_fw_assisted_mclk_switch_config *config_data = &cmd.fw_assisted_mclk_switch.config_data;
    int i = 0;
    int ramp_up_num_steps = 1; // TODO: Ramp is currently disabled. Reenable it.
    - uint8_t visual_confirm_enabled = dc->debug.visual_confirm == VISUAL_CONFIRM_FAMS;
    + uint8_t visual_confirm_enabled;

    if (dc == NULL)
    return false;

    + visual_confirm_enabled = dc->debug.visual_confirm == VISUAL_CONFIRM_FAMS;
    +
    // Format command.
    cmd.fw_assisted_mclk_switch.header.type = DMUB_CMD__FW_ASSISTED_MCLK_SWITCH;
    cmd.fw_assisted_mclk_switch.header.sub_type = DMUB_CMD__FAMS_SETUP_FW_CTRL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:58    [W:3.253 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site