lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 711/862] bnxt_en: replace reset with config timestamps
    Date
    From: Vadim Fedorenko <vfedorenko@novek.ru>

    [ Upstream commit 8db3d514e96715c897fe793c4d5fc0fd86aca517 ]

    Any change to the hardware timestamps configuration triggers nic restart,
    which breaks transmition and reception of network packets for a while.
    But there is no need to fully restart the device because while configuring
    hardware timestamps. The code for changing configuration runs after all
    of the initialisation, when the NIC is actually up and running. This patch
    changes the code that ioctl will only update configuration registers and
    will not trigger carrier status change, but in case of timestamps for
    all rx packetes it fallbacks to close()/open() sequnce because of
    synchronization issues in the hardware. Tested on BCM57504.

    Cc: Richard Cochran <richardcochran@gmail.com>
    Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
    Reviewed-by: Michael Chan <michael.chan@broadcom.com>
    Link: https://lore.kernel.org/r/20220922191038.29921-1-vfedorenko@novek.ru
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
    index 8e316367f6ce..2132ce63193c 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
    @@ -505,9 +505,13 @@ static int bnxt_hwrm_ptp_cfg(struct bnxt *bp)
    ptp->tstamp_filters = flags;

    if (netif_running(bp->dev)) {
    - rc = bnxt_close_nic(bp, false, false);
    - if (!rc)
    - rc = bnxt_open_nic(bp, false, false);
    + if (ptp->rx_filter == HWTSTAMP_FILTER_ALL) {
    + rc = bnxt_close_nic(bp, false, false);
    + if (!rc)
    + rc = bnxt_open_nic(bp, false, false);
    + } else {
    + bnxt_ptp_cfg_tstamp_filters(bp);
    + }
    if (!rc && !ptp->tstamp_filters)
    rc = -EIO;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:52    [W:2.386 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site