lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 471/862] clk: qoriq: Hold reference returned by of_get_parent()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit a8ea4273bc26256ce3cce83164f0f51c5bf6e127 ]

    In legacy_init_clockgen(), we need to hold the reference returned
    by of_get_parent() and use it to call of_node_put() for refcount
    balance.

    Beside, in create_sysclk(), we need to call of_node_put() on 'sysclk'
    also for refcount balance.

    Fixes: 0dfc86b3173f ("clk: qoriq: Move chip-specific knowledge into driver")
    Signed-off-by: Liang He <windhl@126.com>
    Link: https://lore.kernel.org/r/20220628143851.171299-1-windhl@126.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/clk-qoriq.c | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
    index 88898b97a443..5eddb9f0d6bd 100644
    --- a/drivers/clk/clk-qoriq.c
    +++ b/drivers/clk/clk-qoriq.c
    @@ -1063,8 +1063,13 @@ static void __init _clockgen_init(struct device_node *np, bool legacy);
    */
    static void __init legacy_init_clockgen(struct device_node *np)
    {
    - if (!clockgen.node)
    - _clockgen_init(of_get_parent(np), true);
    + if (!clockgen.node) {
    + struct device_node *parent_np;
    +
    + parent_np = of_get_parent(np);
    + _clockgen_init(parent_np, true);
    + of_node_put(parent_np);
    + }
    }

    /* Legacy node */
    @@ -1159,6 +1164,7 @@ static struct clk * __init create_sysclk(const char *name)
    sysclk = of_get_child_by_name(clockgen.node, "sysclk");
    if (sysclk) {
    clk = sysclk_from_fixed(sysclk, name);
    + of_node_put(sysclk);
    if (!IS_ERR(clk))
    return clk;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:50    [W:3.987 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site