lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 287/862] wifi: mt76: mt7921: add mt7921_mutex_acquire at mt7921_sta_set_decap_offload
    Date
    From: Sean Wang <sean.wang@mediatek.com>

    [ Upstream commit 59c20b91786d5f140ee7be2f24c242b5f8986046 ]

    Add mt7921_mutex_acquire at mt7921_[start, stop]_ap to fix the race
    with the context holding dev->muxtex and the driver might access the
    device in low power state.

    Fixes: 24299fc869f7 ("mt76: mt7921: enable rx header traslation offload")
    Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Sean Wang <sean.wang@mediatek.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7921/main.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    index 63fd33dcd3af..7214735011d0 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    @@ -1404,6 +1404,8 @@ static void mt7921_sta_set_decap_offload(struct ieee80211_hw *hw,
    struct mt7921_sta *msta = (struct mt7921_sta *)sta->drv_priv;
    struct mt7921_dev *dev = mt7921_hw_dev(hw);

    + mt7921_mutex_acquire(dev);
    +
    if (enabled)
    set_bit(MT_WCID_FLAG_HDR_TRANS, &msta->wcid.flags);
    else
    @@ -1411,6 +1413,8 @@ static void mt7921_sta_set_decap_offload(struct ieee80211_hw *hw,

    mt76_connac_mcu_sta_update_hdr_trans(&dev->mt76, vif, &msta->wcid,
    MCU_UNI_CMD(STA_REC_UPDATE));
    +
    + mt7921_mutex_release(dev);
    }

    #if IS_ENABLED(CONFIG_IPV6)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:41    [W:4.020 / U:1.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site