lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 796/862] RDMA/rxe: Delete error messages triggered by incoming Read requests
    Date
    From: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>

    [ Upstream commit 2c02249fcbfc066bd33e2a7375c7006d4cb367f6 ]

    An incoming Read request causes multiple Read responses. If a user MR to
    copy data from is unavailable or responder cannot send a reply, then the
    error messages can be printed for each response attempt, resulting in
    message overflow.

    Link: https://lore.kernel.org/r/20220829071218.1639065-1-matsuda-daisuke@fujitsu.com
    Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
    index b36ec5c4d5e0..7c336db5cb54 100644
    --- a/drivers/infiniband/sw/rxe/rxe_resp.c
    +++ b/drivers/infiniband/sw/rxe/rxe_resp.c
    @@ -809,10 +809,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
    if (!skb)
    return RESPST_ERR_RNR;

    - err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
    - payload, RXE_FROM_MR_OBJ);
    - if (err)
    - pr_err("Failed copying memory\n");
    + rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
    + payload, RXE_FROM_MR_OBJ);
    if (mr)
    rxe_put(mr);

    @@ -823,10 +821,8 @@ static enum resp_states read_reply(struct rxe_qp *qp,
    }

    err = rxe_xmit_packet(qp, &ack_pkt, skb);
    - if (err) {
    - pr_err("Failed sending RDMA reply.\n");
    + if (err)
    return RESPST_ERR_RNR;
    - }

    res->read.va += payload;
    res->read.resid -= payload;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:41    [W:3.072 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site