lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 806/862] staging: vt6655: fix potential memory leak
    Date
    From: Nam Cao <namcaov@gmail.com>

    [ Upstream commit c8ff91535880d41b49699b3829fb6151942de29e ]

    In function device_init_td0_ring, memory is allocated for member
    td_info of priv->apTD0Rings[i], with i increasing from 0. In case of
    allocation failure, the memory is freed in reversed order, with i
    decreasing to 0. However, the case i=0 is left out and thus memory is
    leaked.

    Modify the memory freeing loop to include the case i=0.

    Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
    Signed-off-by: Nam Cao <namcaov@gmail.com>
    Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/vt6655/device_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
    index d76f65756db8..ec7c991e745b 100644
    --- a/drivers/staging/vt6655/device_main.c
    +++ b/drivers/staging/vt6655/device_main.c
    @@ -694,7 +694,7 @@ static int device_init_td0_ring(struct vnt_private *priv)
    return 0;

    err_free_desc:
    - while (--i) {
    + while (i--) {
    desc = &priv->apTD0Rings[i];
    kfree(desc->td_info);
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 12:41    [W:3.221 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site