lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 835/862] fsi: master-ast-cf: Fix missing of_node_put in fsi_master_acf_probe
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit 182d98e00e4745fe253cb0c24c63bbac253464a2 ]

    of_parse_phandle returns node pointer with refcount incremented, use
    of_node_put() on it when done.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Link: https://lore.kernel.org/r/20220407085911.2491719-1-lv.ruyi@zte.com.cn
    Signed-off-by: Joel Stanley <joel@jms.id.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fsi/fsi-master-ast-cf.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
    index 24292acdbaf8..5f608ef8b53c 100644
    --- a/drivers/fsi/fsi-master-ast-cf.c
    +++ b/drivers/fsi/fsi-master-ast-cf.c
    @@ -1324,12 +1324,14 @@ static int fsi_master_acf_probe(struct platform_device *pdev)
    }
    master->cvic = devm_of_iomap(&pdev->dev, np, 0, NULL);
    if (IS_ERR(master->cvic)) {
    + of_node_put(np);
    rc = PTR_ERR(master->cvic);
    dev_err(&pdev->dev, "Error %d mapping CVIC\n", rc);
    goto err_free;
    }
    rc = of_property_read_u32(np, "copro-sw-interrupts",
    &master->cvic_sw_irq);
    + of_node_put(np);
    if (rc) {
    dev_err(&pdev->dev, "Can't find coprocessor SW interrupt\n");
    goto err_free;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:47    [W:2.787 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site