lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 837/862] usb: typec: ucsi: Dont warn on probe deferral
    Date
    From: Wayne Chang <waynec@nvidia.com>

    [ Upstream commit fce703a991b7e8c7e1371de95b9abaa832ecf9c3 ]

    Deferred probe is an expected return value for fwnode_usb_role_switch_get().
    Given that the driver deals with it properly, there's no need to output a
    warning that may potentially confuse users.

    --
    V2 -> V3: remove the Fixes and Cc
    V1 -> V2: adjust the coding style for better reading format.
    drivers/usb/typec/ucsi/ucsi.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    Signed-off-by: Wayne Chang <waynec@nvidia.com>
    Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Link: https://lore.kernel.org/r/20220927134512.2651067-1-waynec@nvidia.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/typec/ucsi/ucsi.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
    index 6364f0d467ea..74fb5a4c6f21 100644
    --- a/drivers/usb/typec/ucsi/ucsi.c
    +++ b/drivers/usb/typec/ucsi/ucsi.c
    @@ -1067,11 +1067,9 @@ static int ucsi_register_port(struct ucsi *ucsi, int index)

    cap->fwnode = ucsi_find_fwnode(con);
    con->usb_role_sw = fwnode_usb_role_switch_get(cap->fwnode);
    - if (IS_ERR(con->usb_role_sw)) {
    - dev_err(ucsi->dev, "con%d: failed to get usb role switch\n",
    - con->num);
    - return PTR_ERR(con->usb_role_sw);
    - }
    + if (IS_ERR(con->usb_role_sw))
    + return dev_err_probe(ucsi->dev, PTR_ERR(con->usb_role_sw),
    + "con%d: failed to get usb role switch\n", con->num);

    /* Delay other interactions with the con until registration is complete */
    mutex_lock(&con->lock);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:43    [W:4.044 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site