lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 557/862] drivers: serial: jsm: fix some leaks in probe
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 1d5859ef229e381f4db38dce8ed58e4bf862006b ]

    This error path needs to unwind instead of just returning directly.

    Fixes: 03a8482c17dd ("drivers: serial: jsm: Enable support for Digi Classic adapters")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/YyxFh1+lOeZ9WfKO@kili
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/jsm/jsm_driver.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c
    index 0ea799bf8dbb..417a5b6bffc3 100644
    --- a/drivers/tty/serial/jsm/jsm_driver.c
    +++ b/drivers/tty/serial/jsm/jsm_driver.c
    @@ -211,7 +211,8 @@ static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)

    break;
    default:
    - return -ENXIO;
    + rc = -ENXIO;
    + goto out_kfree_brd;
    }

    rc = request_irq(brd->irq, brd->bd_ops->intr, IRQF_SHARED, "JSM", brd);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:34    [W:4.017 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site