lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 732/862] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()
    Date
    From: Zeng Jingxiang <linuszeng@tencent.com>

    [ Upstream commit ef8886f321c5dab8124b9153d25afa2a71d05323 ]

    A NULL check for bridge->encoder shows that it may be NULL, but it
    already been dereferenced on all paths leading to the check.
    812 if (!bridge->encoder) {

    Dereference the pointer bridge->encoder.
    810 drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

    Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com>
    Signed-off-by: Robert Foss <robert.foss@linaro.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220727073119.1578972-1-zengjx95@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/lontium-lt9611.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
    index 8a60e83482a0..5fccacc159f0 100644
    --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
    +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
    @@ -813,13 +813,14 @@ static int lt9611_connector_init(struct drm_bridge *bridge, struct lt9611 *lt961

    drm_connector_helper_add(&lt9611->connector,
    &lt9611_bridge_connector_helper_funcs);
    - drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);

    if (!bridge->encoder) {
    DRM_ERROR("Parent encoder object not found");
    return -ENODEV;
    }

    + drm_connector_attach_encoder(&lt9611->connector, bridge->encoder);
    +
    return 0;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:32    [W:4.767 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site