lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 486/862] media: airspy: fix memory leak in airspy probe
    Date
    From: Dongliang Mu <mudongliangabcd@gmail.com>

    [ Upstream commit 23bc5eb55f8c9607965c20d9ddcc13cb1ae59568 ]

    The commit ca9dc8d06ab6 ("media: airspy: respect the DMA coherency
    rules") moves variable buf from stack to heap, however, it only frees
    buf in the error handling code, missing deallocation in the success
    path.

    Fix this by freeing buf in the success path since this variable does not
    have any references in other code.

    Fixes: ca9dc8d06ab6 ("media: airspy: respect the DMA coherency rules")
    Reported-by: syzbot+bb25f85e5aa482864dc0@syzkaller.appspotmail.com
    Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolution.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/usb/airspy/airspy.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
    index 240a7cc56777..7b1c40132555 100644
    --- a/drivers/media/usb/airspy/airspy.c
    +++ b/drivers/media/usb/airspy/airspy.c
    @@ -1070,6 +1070,10 @@ static int airspy_probe(struct usb_interface *intf,
    ret);
    goto err_free_controls;
    }
    +
    + /* Free buf if success*/
    + kfree(buf);
    +
    dev_info(s->dev, "Registered as %s\n",
    video_device_node_name(&s->vdev));
    dev_notice(s->dev, "SDR API is still slightly experimental and functionality changes may follow\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:23    [W:3.787 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site