lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 598/862] clk: imx: scu: fix memleak on platform_device_add() fails
    Date
    From: Lin Yujun <linyujun809@huawei.com>

    [ Upstream commit 855ae87a2073ebf1b395e020de54fdf9ce7d166f ]

    No error handling is performed when platform_device_add()
    fails. Add error processing before return, and modified
    the return value.

    Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support")
    Signed-off-by: Lin Yujun <linyujun809@huawei.com>
    Link: https://lore.kernel.org/r/20220914033206.98046-1-linyujun809@huawei.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/imx/clk-scu.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
    index c56e406138db..1e6870f3671f 100644
    --- a/drivers/clk/imx/clk-scu.c
    +++ b/drivers/clk/imx/clk-scu.c
    @@ -695,7 +695,11 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name,
    pr_warn("%s: failed to attached the power domain %d\n",
    name, ret);

    - platform_device_add(pdev);
    + ret = platform_device_add(pdev);
    + if (ret) {
    + platform_device_put(pdev);
    + return ERR_PTR(ret);
    + }

    /* For API backwards compatiblilty, simply return NULL for success */
    return NULL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:21    [W:2.794 / U:1.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site