Messages in this thread | | | Date | Wed, 19 Oct 2022 11:30:51 +0530 | Subject | Re: [PATCH v2] ASoC: simple-card: Fix up checks for HW param fixups | From | Sameer Pujar <> |
| |
On 19-10-2022 06:53, Aidan MacDonald wrote: > The "convert-xxx" properties only have an effect for DPCM DAI links. > A DAI link is only created as DPCM if the device tree requires it; > part of this involves checking for the use of "convert-xxx" properties. > > When the convert-sample-format property was added, the checks got out > of sync. A DAI link that specified only convert-sample-format but did > not pass any of the other DPCM checks would not go into DPCM mode and > the convert-sample-format property would be silently ignored. > > Fix this by adding a function to do the "convert-xxx" property checks, > instead of open-coding it in simple-card and audio-graph-card. And add > "convert-sample-format" to the check function so that DAI links using > it will be initialized correctly. > > Fixes: 047a05366f4b ("ASoC: simple-card-utils: Fixup DAI sample format") > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com> > --- > v2: Rename helper function to asoc_simple_is_convert_required() as > suggested by Kuninori Morimoto. > > include/sound/simple_card_utils.h | 1 + > sound/soc/generic/audio-graph-card.c | 2 +- > sound/soc/generic/simple-card-utils.c | 15 +++++++++++++++ > sound/soc/generic/simple-card.c | 3 +-- > 4 files changed, 18 insertions(+), 3 deletions(-)
Acked-by: Sameer Pujar <spujar@nvidia.com>
| |