lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 464/862] iio: magnetometer: yas530: Change data type of hard_offsets to signed
    Date
    From: Jakob Hauser <jahau@rocketmail.com>

    [ Upstream commit e137fafc8985cf152a4bb6f18ae83ebb06816df1 ]

    The "hard_offsets" are currently unsigned u8 but they should be signed as they
    can get negative. They are signed in function yas5xx_meaure_offsets() and in the
    Yamaha drivers [1][2].

    [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156
    [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91

    Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530")
    Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Link: https://lore.kernel.org/r/40f052bf6491457d0c5c0ed4c3534dc6fa251c3c.1660337264.git.jahau@rocketmail.com
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/magnetometer/yamaha-yas530.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
    index aeaa4da6923b..d1f16729c60e 100644
    --- a/drivers/iio/magnetometer/yamaha-yas530.c
    +++ b/drivers/iio/magnetometer/yamaha-yas530.c
    @@ -132,7 +132,7 @@ struct yas5xx {
    unsigned int version;
    char name[16];
    struct yas5xx_calibration calibration;
    - u8 hard_offsets[3];
    + s8 hard_offsets[3];
    struct iio_mount_matrix orientation;
    struct regmap *map;
    struct regulator_bulk_data regs[2];
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:14    [W:4.111 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site