lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 451/862] arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2
    Date
    From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

    [ Upstream commit bd1a665a01b4d65fd8dc6fece4b376fa5c8c55bb ]

    According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
    when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
    when chip is in use.

    s3fwrn5_phy_power_ctrl():

    ...
    gpio_set_value(phy->gpio_en, 1);
    ...
    if (mode != S3FWRN5_MODE_COLD) {
    msleep(S3FWRN5_EN_WAIT_TIME);
    gpio_set_value(phy->gpio_en, 0);
    msleep(S3FWRN5_EN_WAIT_TIME);
    }

    Therefore the line described by "en-gpios" property should be annotated
    as "active low".

    The wakeup gpio appears to have correct polarity (active high).

    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Link: https://lore.kernel.org/r/20220929011557.4165216-1-dmitry.torokhov@gmail.com
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
    +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
    @@ -795,7 +795,7 @@
    reg = <0x27>;
    interrupt-parent = <&gpa1>;
    interrupts = <3 IRQ_TYPE_EDGE_RISING>;
    - en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
    + en-gpios = <&gpf1 4 GPIO_ACTIVE_LOW>;
    wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
    };
    };

    \
     
     \ /
      Last update: 2022-10-19 11:12    [W:8.329 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site