lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 417/862] memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 48af14fb0eaa63d9aa68f59fb0b205ec55a95636 ]

    We should add the of_node_put() when breaking out of
    for_each_child_of_node() as it will automatically increase
    and decrease the refcount.

    Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/memory/of_memory.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
    index 8e2ef4bf6b17..fcd20d85d385 100644
    --- a/drivers/memory/of_memory.c
    +++ b/drivers/memory/of_memory.c
    @@ -285,6 +285,7 @@ const struct lpddr3_timings
    if (of_device_is_compatible(np_tim, tim_compat)) {
    if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {
    devm_kfree(dev, timings);
    + of_node_put(np_tim);
    goto default_timings;
    }
    i++;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:12    [W:2.390 / U:0.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site