lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 280/862] wifi: mt76: mt7915: fix an uninitialized variable bug
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit b5ee771c84082b4e54cc39d9d9a2dd239e4f6b86 ]

    Smatch complains that:

    drivers/net/wireless/mediatek/mt76/mt7915/mac.c:428 mt7915_mac_fill_rx()
    error: uninitialized symbol 'msta'.

    It looks like this was supposed to be initialized to NULL.

    Fixes: 0880d40871d1 ("mt76: connac: move mt76_connac2_reverse_frag0_hdr_trans in mt76-connac module")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    index 60ae834d95a6..4ddcd3afa428 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    @@ -232,7 +232,7 @@ mt7915_mac_fill_rx(struct mt7915_dev *dev, struct sk_buff *skb)
    bool unicast, insert_ccmp_hdr = false;
    u8 remove_pad, amsdu_info;
    u8 mode = 0, qos_ctl = 0;
    - struct mt7915_sta *msta;
    + struct mt7915_sta *msta = NULL;
    bool hdr_trans;
    u16 hdr_gap;
    u16 seq_ctrl = 0;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:08    [W:2.904 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site