lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 364/862] platform/chrome: fix memory corruption in ioctl
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 8a07b45fd3c2dda24fad43639be5335a4595196a ]

    If "s_mem.bytes" is larger than the buffer size it leads to memory
    corruption.

    Fixes: eda2e30c6684 ("mfd / platform: cros_ec: Miscellaneous character device to talk with the EC")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
    Link: https://lore.kernel.org/r/Yv8dpCFZJdbUT5ye@kili
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/chrome/cros_ec_chardev.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/platform/chrome/cros_ec_chardev.c b/drivers/platform/chrome/cros_ec_chardev.c
    index fd33de546aee..0de7c255254e 100644
    --- a/drivers/platform/chrome/cros_ec_chardev.c
    +++ b/drivers/platform/chrome/cros_ec_chardev.c
    @@ -327,6 +327,9 @@ static long cros_ec_chardev_ioctl_readmem(struct cros_ec_dev *ec,
    if (copy_from_user(&s_mem, arg, sizeof(s_mem)))
    return -EFAULT;

    + if (s_mem.bytes > sizeof(s_mem.buffer))
    + return -EINVAL;
    +
    num = ec_dev->cmd_readmem(ec_dev, s_mem.offset, s_mem.bytes,
    s_mem.buffer);
    if (num <= 0)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:05    [W:2.355 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site