lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 341/862] eth: sp7021: fix use after free bug in spl2sw_nvmem_get_mac_address
    Date
    From: Zheng Wang <zyytlz.wz@163.com>

    [ Upstream commit 12aece8b01507a2d357a1861f470e83621fbb6f2 ]

    This frees "mac" and tries to display its address as part of the error
    message on the next line. Swap the order.

    Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021")
    Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
    index 546206640492..61d1d07dc070 100644
    --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
    +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
    @@ -248,8 +248,8 @@ static int spl2sw_nvmem_get_mac_address(struct device *dev, struct device_node *

    /* Check if mac address is valid */
    if (!is_valid_ether_addr(mac)) {
    - kfree(mac);
    dev_info(dev, "Invalid mac address in nvmem (%pM)!\n", mac);
    + kfree(mac);
    return -EINVAL;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:05    [W:4.047 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site