lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 348/862] drm/bridge: Avoid uninitialized variable warning
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 7d1202738efda60155d98b370b3c70d336be0eea ]

    This code works, but technically it uses "num_in_bus_fmts" before it
    has been initialized so it leads to static checker warnings and probably
    KMEMsan warnings at run time. Initialize the variable to zero to
    silence the warning.

    Fixes: f32df58acc68 ("drm/bridge: Add the necessary bits to support bus format negotiation")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/YrrIs3hoGcPVmXc5@kili
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/drm_bridge.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
    index 6abf7a2407e9..1545c50fd1c8 100644
    --- a/drivers/gpu/drm/drm_bridge.c
    +++ b/drivers/gpu/drm/drm_bridge.c
    @@ -847,8 +847,8 @@ static int select_bus_fmt_recursive(struct drm_bridge *first_bridge,
    struct drm_connector_state *conn_state,
    u32 out_bus_fmt)
    {
    + unsigned int i, num_in_bus_fmts = 0;
    struct drm_bridge_state *cur_state;
    - unsigned int num_in_bus_fmts, i;
    struct drm_bridge *prev_bridge;
    u32 *in_bus_fmts;
    int ret;
    @@ -969,7 +969,7 @@ drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge,
    struct drm_connector *conn = conn_state->connector;
    struct drm_encoder *encoder = bridge->encoder;
    struct drm_bridge_state *last_bridge_state;
    - unsigned int i, num_out_bus_fmts;
    + unsigned int i, num_out_bus_fmts = 0;
    struct drm_bridge *last_bridge;
    u32 *out_bus_fmts;
    int ret = 0;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 11:03    [W:2.564 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site