lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 129/862] f2fs: allow direct read for zoned device
    Date
    From: Jaegeuk Kim <jaegeuk@kernel.org>

    commit 689fe57e7ecefd2eeba76c32aa569bb3e1e790d9 upstream.

    This reverts dbf8e63f48af ("f2fs: remove device type check for direct IO"),
    and apply the below first version, since it contributed out-of-order DIO writes.

    For zoned devices, f2fs forbids direct IO and forces buffered IO
    to serialize write IOs. However, the constraint does not apply to
    read IOs.

    Cc: stable@vger.kernel.org
    Fixes: dbf8e63f48af ("f2fs: remove device type check for direct IO")
    Signed-off-by: Eunhee Rho <eunhee83.rho@samsung.com>
    Reviewed-by: Chao Yu <chao@kernel.org>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/f2fs/f2fs.h | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/fs/f2fs/f2fs.h
    +++ b/fs/f2fs/f2fs.h
    @@ -4513,7 +4513,12 @@ static inline bool f2fs_force_buffered_i
    /* disallow direct IO if any of devices has unaligned blksize */
    if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)
    return true;
    -
    + /*
    + * for blkzoned device, fallback direct IO to buffered IO, so
    + * all IOs can be serialized by log-structured write.
    + */
    + if (f2fs_sb_has_blkzoned(sbi) && (rw == WRITE))
    + return true;
    if (f2fs_lfs_mode(sbi) && (rw == WRITE)) {
    if (block_unaligned_IO(inode, iocb, iter))
    return true;

    \
     
     \ /
      Last update: 2022-10-19 11:01    [W:2.471 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site