lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 071/862] dmaengine: mxs: use platform_driver_register
    Date
    From: Dario Binacchi <dario.binacchi@amarulasolutions.com>

    commit 26696d4657167112a1079f86cba1739765c1360e upstream.

    Driver registration fails on SOC imx8mn as its supplier, the clock
    control module, is probed later than subsys initcall level. This driver
    uses platform_driver_probe which is not compatible with deferred probing
    and won't be probed again later if probe function fails due to clock not
    being available at that time.

    This patch replaces the use of platform_driver_probe with
    platform_driver_register which will allow probing the driver later again
    when the clock control module will be available.

    The __init annotation has been dropped because it is not compatible with
    deferred probing. The code is not executed once and its memory cannot be
    freed.

    Fixes: a580b8c5429a ("dmaengine: mxs-dma: add dma support for i.MX23/28")
    Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
    Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
    Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
    Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    Link: https://lore.kernel.org/r/20220921170556.1055962-1-dario.binacchi@amarulasolutions.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    ---
    drivers/dma/mxs-dma.c | 11 ++++-------
    1 file changed, 4 insertions(+), 7 deletions(-)

    --- a/drivers/dma/mxs-dma.c
    +++ b/drivers/dma/mxs-dma.c
    @@ -670,7 +670,7 @@ static enum dma_status mxs_dma_tx_status
    return mxs_chan->status;
    }

    -static int __init mxs_dma_init(struct mxs_dma_engine *mxs_dma)
    +static int mxs_dma_init(struct mxs_dma_engine *mxs_dma)
    {
    int ret;

    @@ -741,7 +741,7 @@ static struct dma_chan *mxs_dma_xlate(st
    ofdma->of_node);
    }

    -static int __init mxs_dma_probe(struct platform_device *pdev)
    +static int mxs_dma_probe(struct platform_device *pdev)
    {
    struct device_node *np = pdev->dev.of_node;
    const struct mxs_dma_type *dma_type;
    @@ -839,10 +839,7 @@ static struct platform_driver mxs_dma_dr
    .name = "mxs-dma",
    .of_match_table = mxs_dma_dt_ids,
    },
    + .probe = mxs_dma_probe,
    };

    -static int __init mxs_dma_module_init(void)
    -{
    - return platform_driver_probe(&mxs_dma_driver, mxs_dma_probe);
    -}
    -subsys_initcall(mxs_dma_module_init);
    +builtin_platform_driver(mxs_dma_driver);

    \
     
     \ /
      Last update: 2022-10-19 11:00    [W:4.090 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site