lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 281/862] wifi: mt76: mt7921: fix use after free in mt7921_acpi_read()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e7de4b4979bd8d313ec837931dde936653ca82ea ]

    Don't dereference "sar_root" after it has been freed.

    Fixes: f965333e491e ("mt76: mt7921: introduce ACPI SAR support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7921/acpi_sar.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/acpi_sar.c b/drivers/net/wireless/mediatek/mt76/mt7921/acpi_sar.c
    index be4f07ad3af9..47e034a9b003 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7921/acpi_sar.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7921/acpi_sar.c
    @@ -13,6 +13,7 @@ mt7921_acpi_read(struct mt7921_dev *dev, u8 *method, u8 **tbl, u32 *len)
    acpi_handle root, handle;
    acpi_status status;
    u32 i = 0;
    + int ret;

    root = ACPI_HANDLE(mdev->dev);
    if (!root)
    @@ -52,9 +53,11 @@ mt7921_acpi_read(struct mt7921_dev *dev, u8 *method, u8 **tbl, u32 *len)
    *(*tbl + i) = (u8)sar_unit->integer.value;
    }
    free:
    + ret = (i == sar_root->package.count) ? 0 : -EINVAL;
    +
    kfree(sar_root);

    - return (i == sar_root->package.count) ? 0 : -EINVAL;
    + return ret;
    }

    /* MTCL : Country List Table for 6G band */
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 10:58    [W:2.418 / U:2.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site