lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 217/862] ACPI: PCC: Release resources on address space setup failure path
    Date
    From: Rafael Mendonca <rafaelmendsr@gmail.com>

    [ Upstream commit f890157e61b85ce8ae01a41ffa375e3b99853698 ]

    The allocated memory for the pcc_data struct doesn't get freed under an
    error path in pcc_mbox_request_channel() or acpi_os_ioremap(). Also, the
    PCC mailbox channel doesn't get freed under an error path in
    acpi_os_ioremap().

    Fixes: 77e2a04745ff8 ("ACPI: PCC: Implement OperationRegion handler for the PCC Type 3 subtype")
    Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
    Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/acpi_pcc.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
    index a12b55d81209..84f1ac416b57 100644
    --- a/drivers/acpi/acpi_pcc.c
    +++ b/drivers/acpi/acpi_pcc.c
    @@ -63,6 +63,7 @@ acpi_pcc_address_space_setup(acpi_handle region_handle, u32 function,
    if (IS_ERR(data->pcc_chan)) {
    pr_err("Failed to find PCC channel for subspace %d\n",
    ctx->subspace_id);
    + kfree(data);
    return AE_NOT_FOUND;
    }

    @@ -72,6 +73,8 @@ acpi_pcc_address_space_setup(acpi_handle region_handle, u32 function,
    if (!data->pcc_comm_addr) {
    pr_err("Failed to ioremap PCC comm region mem for %d\n",
    ctx->subspace_id);
    + pcc_mbox_free_channel(data->pcc_chan);
    + kfree(data);
    return AE_NO_MEMORY;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-10-19 10:53    [W:2.319 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site