lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 048/862] platform/chrome: cros_ec_proto: Update version on GET_NEXT_EVENT failure
    Date
    From: Patryk Duda <pdk@semihalf.com>

    commit f74c7557ed0d321947e8bb4e9d47c1013f8b2227 upstream.

    Some EC based devices (e.g. Fingerpint MCU) can jump to RO part of the
    firmware (intentionally or due to device reboot). The RO part doesn't
    change during the device lifecycle, so it won't support newer version
    of EC_CMD_GET_NEXT_EVENT command.

    Function cros_ec_query_all() is responsible for finding maximum
    supported MKBP event version. It's usually called when the device is
    running RW part of the firmware, so the command version can be
    potentially higher than version supported by the RO.

    The problem was fixed by updating maximum supported version when the
    device returns EC_RES_INVALID_VERSION (mapped to -ENOPROTOOPT). That way
    the kernel will use highest common version supported by RO and RW.

    Fixes: 3300fdd630d4 ("platform/chrome: cros_ec: handle MKBP more events flag")
    Cc: <stable@vger.kernel.org> # 5.10+
    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Patryk Duda <pdk@semihalf.com>
    Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
    Link: https://lore.kernel.org/r/20220802154128.21175-1-pdk@semihalf.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/chrome/cros_ec_proto.c | 32 ++++++++++++++++++++++++++++++++
    1 file changed, 32 insertions(+)

    --- a/drivers/platform/chrome/cros_ec_proto.c
    +++ b/drivers/platform/chrome/cros_ec_proto.c
    @@ -773,6 +773,7 @@ int cros_ec_get_next_event(struct cros_e
    u8 event_type;
    u32 host_event;
    int ret;
    + u32 ver_mask;

    /*
    * Default value for wake_event.
    @@ -794,6 +795,37 @@ int cros_ec_get_next_event(struct cros_e
    return get_keyboard_state_event(ec_dev);

    ret = get_next_event(ec_dev);
    + /*
    + * -ENOPROTOOPT is returned when EC returns EC_RES_INVALID_VERSION.
    + * This can occur when EC based device (e.g. Fingerprint MCU) jumps to
    + * the RO image which doesn't support newer version of the command. In
    + * this case we will attempt to update maximum supported version of the
    + * EC_CMD_GET_NEXT_EVENT.
    + */
    + if (ret == -ENOPROTOOPT) {
    + dev_dbg(ec_dev->dev,
    + "GET_NEXT_EVENT returned invalid version error.\n");
    + ret = cros_ec_get_host_command_version_mask(ec_dev,
    + EC_CMD_GET_NEXT_EVENT,
    + &ver_mask);
    + if (ret < 0 || ver_mask == 0)
    + /*
    + * Do not change the MKBP supported version if we can't
    + * obtain supported version correctly. Please note that
    + * calling EC_CMD_GET_NEXT_EVENT returned
    + * EC_RES_INVALID_VERSION which means that the command
    + * is present.
    + */
    + return -ENOPROTOOPT;
    +
    + ec_dev->mkbp_event_supported = fls(ver_mask);
    + dev_dbg(ec_dev->dev, "MKBP support version changed to %u\n",
    + ec_dev->mkbp_event_supported - 1);
    +
    + /* Try to get next event with new MKBP support version set. */
    + ret = get_next_event(ec_dev);
    + }
    +
    if (ret <= 0)
    return ret;


    \
     
     \ /
      Last update: 2022-10-19 10:44    [W:2.563 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site