Messages in this thread | | | Date | Wed, 19 Oct 2022 16:37:03 -0700 | Subject | Re: [PATCH v2] net: macb: Specify PHY PM management done by MAC | From | Florian Fainelli <> |
| |
On 10/19/2022 5:09 AM, Sergiu Moga wrote: > The `macb_resume`/`macb_suspend` methods already call the > `phylink_start`/`phylink_stop` methods during their execution so > explicitly say that the PM of the PHY is done by MAC by using the > `mac_managed_pm` flag of the `struct phylink_config`. > > This also fixes the warning message issued during resume: > WARNING: CPU: 0 PID: 237 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0x144/0x148 > > Depends-on: 96de900ae78e ("net: phylink: add mac_managed_pm in phylink_config structure") > Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state") > Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Makes me realize we need to do the same in DSA, I will cook a patch soon. -- Florian
| |