lkml.org 
[lkml]   [2022]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6.0 029/862] xhci: dbc: Fix memory leak in xhci_alloc_dbc()
    Date
    From: Rafael Mendonca <rafaelmendsr@gmail.com>

    commit d591b32e519603524a35b172156db71df9116902 upstream.

    If DbC is already in use, then the allocated memory for the xhci_dbc struct
    doesn't get freed before returning NULL, which leads to a memleak.

    Fixes: 534675942e90 ("xhci: dbc: refactor xhci_dbc_init()")
    Cc: stable@vger.kernel.org
    Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
    Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
    Link: https://lore.kernel.org/r/20220921123450.671459-3-mathias.nyman@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/host/xhci-dbgcap.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/host/xhci-dbgcap.c
    +++ b/drivers/usb/host/xhci-dbgcap.c
    @@ -988,7 +988,7 @@ xhci_alloc_dbc(struct device *dev, void
    dbc->driver = driver;

    if (readl(&dbc->regs->control) & DBC_CTRL_DBC_ENABLE)
    - return NULL;
    + goto err;

    INIT_DELAYED_WORK(&dbc->event_work, xhci_dbc_handle_events);
    spin_lock_init(&dbc->lock);

    \
     
     \ /
      Last update: 2022-10-19 10:44    [W:2.108 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site