Messages in this thread | | | Subject | Re: [PATCH] checkpatch: add warning for non-lore mailing list URLs | From | Joe Perches <> | Date | Wed, 19 Oct 2022 14:12:40 -0700 |
| |
On Wed, 2022-10-19 at 15:28 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > The lkml.org, marc.info, spinics.net, etc archives are not quite as useful > as lore.kernel.org because they use different styles, add advertising, and > may disappear in the future. The lore archives are more consistent and > more likely to stick around, so prefer https://lore.kernel.org URLs when > they exist. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Seems sensible, thanks.
> --- > > Sample commits for testing with "checkpatch -g": > > bd82d4bd2188 www.spinics.net/lists/arm-kernel/msg716956.html > fdec2a9ef853 www.spinics.net/lists/kvm-arm > 1cdca16c043a www.spinics.net/lists/linux-mmc > 48ea02184a9d www.spinics.net/lists/linux-pci > f32ae8a5f131 www.spinics.net/lists/netdev > b7dca6dd1e59 lkml.org > 265df32eae58 lkml.org/lkml/ > 4a9ceb7dbadf marc.info/?l=linux-kernel&m=155656897409107&w=2. > c03914b7aa31 marc.info/?l=linux-mm > f108c887d089 marc.info/?l=linux-netdev > 7424edbb5590 marc.info/?t=156200975600004&r=1&w=2 > dabac6e460ce https://marc.info/?l=linux-rdma&m=152296522708522&w=2 > b02f6a2ef0a1 www.mail-archive.com/linux-kernel@vger.kernel.org > 5e91bf5ce9b8 lists.infradead.org/pipermail/linux-snps-arc/2019-May > 3cde818cd02b mailman.alsa-project.org/pipermail/alsa-devel/2019-January/144761.html > a5448fdc469d http://lists.infradead.org/pipermail/linux-nvme/2019-June/024721.html > > Previously posted: > https://lore.kernel.org/all/20201217235615.43328-1-helgaas@kernel.org/ > https://lore.kernel.org/all/20220401201417.126664-1-helgaas@kernel.org/ > --- > scripts/checkpatch.pl | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 1e5e66ae5a52..4e187202e77a 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -702,6 +702,17 @@ sub find_standard_signature { > return ""; > } > > +our $obsolete_archives = qr{(?xi: > + \Qfreedesktop.org/archives/dri-devel\E | > + \Qlists.infradead.org\E | > + \Qlkml.org\E | > + \Qmail-archive.com\E | > + \Qmailman.alsa-project.org/pipermail\E | > + \Qmarc.info\E | > + \Qozlabs.org/pipermail\E | > + \Qspinics.net\E > +)}; > + > our @typeListMisordered = ( > qr{char\s+(?:un)?signed}, > qr{int\s+(?:(?:un)?signed\s+)?short\s}, > @@ -3324,6 +3335,12 @@ sub process { > $last_git_commit_id_linenr = $linenr if ($line =~ /\bcommit\s*$/i); > } > > +# Check for mailing list archives other than lore.kernel.org > + if ($rawline =~ m{\b$obsolete_archives}) { > + WARN("PREFER_LORE_ARCHIVE", > + "Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr); > + } > + > # Check for added, moved or deleted files > if (!$reported_maintainer_file && !$in_commit_log && > ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
| |