Messages in this thread | | | From | Jason Gerecke <> | Date | Wed, 19 Oct 2022 13:48:14 -0700 | Subject | Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls |
| |
On Wed, Oct 19, 2022 at 1:11 PM Wolfram Sang <wsa-dev@sang-engineering.com> wrote: > > > > > I believe you need to create a coccinelle script and run it over the > > > kernel source tree and then create a patch out of it. > > > > This would definitely be necessary to unify all callers to using > > unsigned variables rather than just swapping which callers generate > > the pointer-sign warnings. > > I am all for using u8 because this is the proper type. > > Yet, if we touch this function argument, I'd also like to remove all > inconsistencies once and for all. Removing some warnings here and add > some there is not a good choice IMO. However, how to do this switch of > types cleanly without too much churn, I sadly have no good idea yet. >
I spent a little time trying to put together a Coccinelle script to take care of everything but I eventually realized the size of the task was larger than I was comfortable with. In particular, even though I might be able to put together a script, I worry I don't have a good way to test the resulting treewide changes to avoid regression.
| |