Messages in this thread | | | From | Dionna Amalie Glaze <> | Date | Wed, 19 Oct 2022 12:58:12 -0700 | Subject | Re: [PATCH] virt/coco/sev-guest: Initialize err in handle_guest_request |
| |
> And currently we have: > > static long snp_guest_ioctl(...) > { > .. > input.fw_err = 0xff; > .. > } > > Which I think is an attempt to make fw_err make sense if the FW is > never called, should we try to maintain that property?
fw_err = 0xff doesn't make sense to me actually. It's not a documented code that the firmware was never called. Still, we can simply pass fw_err to snp_issue_guest_request rather than an unsigned long err, since a null pointer results in an -EINVAL.
-- -Dionna Glaze, PhD (she/her)
| |