Messages in this thread | | | Date | Wed, 19 Oct 2022 11:37:28 -0500 | Subject | Re: [PATCH 02/14] ARM: davinci: drop DAVINCI_DMxxx references | From | David Lechner <> |
| |
On 10/19/22 10:29 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Support for all the dm3xx/dm64xx SoCs is no longer > available, so drop all other references to those. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
> int __init davinci_serial_init(struct platform_device *serial_dev) > diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c > index a9e5c6e91e5d..9dc14c7977b3 100644 > --- a/arch/arm/mach-davinci/usb.c > +++ b/arch/arm/mach-davinci/usb.c > @@ -41,11 +41,6 @@ static struct resource usb_resources[] = { > .flags = IORESOURCE_IRQ, > .name = "mc" > }, > - { > - /* placeholder for the dedicated CPPI IRQ */ > - .flags = IORESOURCE_IRQ, > - .name = "dma" > - }, > }; > > static u64 usb_dmamask = DMA_BIT_MASK(32); > @@ -67,14 +62,6 @@ void __init davinci_setup_usb(unsigned mA, unsigned potpgt_ms) > usb_data.power = mA > 510 ? 255 : mA / 2; > usb_data.potpgt = (potpgt_ms + 1) / 2; > > - if (cpu_is_davinci_dm646x()) { > - /* Override the defaults as DM6467 uses different IRQs. */ > - usb_dev.resource[1].start = DAVINCI_INTC_IRQ(IRQ_DM646X_USBINT); > - usb_dev.resource[2].start = DAVINCI_INTC_IRQ( > - IRQ_DM646X_USBDMAINT); > - } else /* other devices don't have dedicated CPPI IRQ */ > - usb_dev.num_resources = 2; > - > platform_device_register(&usb_dev); > } >
Shouldn't the else case be kept since it applies to *all* "other devices"? (and therfore the usb_resources shouldn't be modified either?)
| |