Messages in this thread | | | Date | Wed, 19 Oct 2022 18:12:18 +0200 | Subject | Re: [PATCH 3/3] raid: substitute empty_zero_page with helper ZERO_PAGE(0) | From | Giulio Benetti <> |
| |
Hi Christoph, All,
On 19/10/22 13:00, Christoph Hellwig wrote: > On Tue, Oct 18, 2022 at 11:57:55PM +0200, Giulio Benetti wrote: >> #if RAID6_USE_EMPTY_ZERO_PAGE >> -# define raid6_empty_zero_page empty_zero_page >> +# define raid6_empty_zero_page ZERO_PAGE(0) >> #else >> extern const char raid6_empty_zero_page[PAGE_SIZE]; > > RAID6_USE_EMPTY_ZERO_PAGE is never set to a non-zero value. So this > is dead code and we can just remove all code related to the > RAID6_USE_EMPTY_ZERO_PAGE case.
Here is a patch that removes that unused code: https://lore.kernel.org/all/20221019160407.7550-1-giulio.benetti@benettiengineering.com/T/#u
and then makes this one useless so I ask to drop it please.
Thank you!
Best regards -- Giulio Benetti CEO/CTO@Benetti Engineering sas
| |